netdev - Re: [PATCH 15/16] vhost-vdpa: account iommu allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Dec 2023 11:09:37 -0500
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Pasha Tatashin <pasha.tatashin@...een.com>
Cc: akpm@...ux-foundation.org, alex.williamson@...hat.com,
	alim.akhtar@...sung.com, alyssa@...enzweig.io,
	asahi@...ts.linux.dev, baolu.lu@...ux.intel.com,
	bhelgaas@...gle.com, cgroups@...r.kernel.org, corbet@....net,
	david@...hat.com, dwmw2@...radead.org, hannes@...xchg.org,
	heiko@...ech.de, iommu@...ts.linux.dev, jasowang@...hat.com,
	jernej.skrabec@...il.com, jgg@...pe.ca, jonathanh@...dia.com,
	joro@...tes.org, kevin.tian@...el.com,
	krzysztof.kozlowski@...aro.org, kvm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-rockchip@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-sunxi@...ts.linux.dev,
	linux-tegra@...r.kernel.org, lizefan.x@...edance.com,
	marcan@...can.st, mhiramat@...nel.org, m.szyprowski@...sung.com,
	netdev@...r.kernel.org, paulmck@...nel.org, rdunlap@...radead.org,
	robin.murphy@....com, samuel@...lland.org,
	suravee.suthikulpanit@....com, sven@...npeter.dev,
	thierry.reding@...il.com, tj@...nel.org, tomas.mudrunka@...il.com,
	vdumpa@...dia.com, virtualization@...ts.linux.dev, wens@...e.org,
	will@...nel.org, yu-cheng.yu@...el.com
Subject: Re: [PATCH 15/16] vhost-vdpa: account iommu allocations

On Tue, Nov 28, 2023 at 08:49:37PM +0000, Pasha Tatashin wrote:
> iommu allocations should be accounted in order to allow admins to
> monitor and limit the amount of iommu memory.
> 
> Signed-off-by: Pasha Tatashin <pasha.tatashin@...een.com>


Acked-by: Michael S. Tsirkin <mst@...hat.com>


> ---
>  drivers/vhost/vdpa.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index da7ec77cdaff..a51c69c078d9 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -968,7 +968,8 @@ static int vhost_vdpa_map(struct vhost_vdpa *v, struct vhost_iotlb *iotlb,
>  			r = ops->set_map(vdpa, asid, iotlb);
>  	} else {
>  		r = iommu_map(v->domain, iova, pa, size,
> -			      perm_to_iommu_flags(perm), GFP_KERNEL);
> +			      perm_to_iommu_flags(perm),
> +			      GFP_KERNEL_ACCOUNT);
>  	}
>  	if (r) {
>  		vhost_iotlb_del_range(iotlb, iova, iova + size - 1);
> -- 
> 2.43.0.rc2.451.g8631bc7472-goog