netdev - Re: [PATCH] net: usb: ax88179_178a: avoid failed operations when device is disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231130084136.172052-1-jtornosm@redhat.com>
Date: Thu, 30 Nov 2023 09:41:36 +0100
From: Jose Ignacio Tornos Martinez <jtornosm@...hat.com>
To: stern@...land.harvard.edu,
	oneukum@...e.com
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	jtornosm@...hat.com,
	kuba@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH] net: usb: ax88179_178a: avoid failed operations when device is disconnected

Hi Oliver,

> I am sorry, but this is a layering violation. You are looking
> at an internal state of the USB layer to surpress logging
> -ENODEV. If you think these messages should go away, filter
> for ENODEV where they are generated.
Thank you for your comments and suggestion.
My intention was also to avoid unnecessary and failed operations 
if disconnection was detected.
Ok, let me research more and do better.

Hi Alan,

> In addition, you should be more careful about the distinction between 
> "unbound" and "disconnected".  It's possible for the driver to be 
> unbound from the device even while the device is still plugged in.  In 
> this situation, submitting URBs will fail with an error even though the 
> device state isn't USB_STATE_NOTATTACHED.
Thank you for you comments.
I also tested "unbound" and stop and unbind operations were correctly 
executed. I just wanted to avoid the issues during disconnection, if other 
operations are commanded later I think it is better to warn.
Ok, I will try to do better.

Best regards
Jose Ignacio