netdev - Re: [PATCHv2 net-next 01/14] selftests/net: add lib.sh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 Nov 2023 11:40:05 +0100
From: Petr Machata <petrm@...dia.com>
To: Hangbin Liu <liuhangbin@...il.com>
CC: <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, "Jakub
 Kicinski" <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>, "Paolo
 Abeni" <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>, David Ahern
	<dsahern@...nel.org>, <linux-kselftest@...r.kernel.org>, Po-Hsu Lin
	<po-hsu.lin@...onical.com>, Guillaume Nault <gnault@...hat.com>, "Petr
 Machata" <petrm@...dia.com>, James Prestwood <prestwoj@...il.com>, "Jaehee
 Park" <jhpark1013@...il.com>, Ido Schimmel <idosch@...dia.com>, "Francesco
 Ruggeri" <fruggeri@...sta.com>, Justin Iurman <justin.iurman@...ege.be>, "Xin
 Long" <lucien.xin@...il.com>
Subject: Re: [PATCHv2 net-next 01/14] selftests/net: add lib.sh


Hangbin Liu <liuhangbin@...il.com> writes:

> Add a lib.sh for net selftests. This file can be used to define commonly
> used variables and functions. Some commonly used functions can be moved
> from forwarding/lib.sh to this lib file. e.g. busywait().
>
> Add function setup_ns() for user to create unique namespaces with given
> prefix name.
>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

LGTM. I took it for a spin with a couple tests that we use for mlxsw,
mainly to make sure the "source ../lib.sh" bit works when invoking tests
from other directories. All seems fine.

Reviewed-by: Petr Machata <petrm@...dia.com>