netdev - Re: [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh to run it in unique namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ab6e843-fd60-4abf-a23f-c8032e617f5c@uliege.be>
Date: Thu, 30 Nov 2023 14:28:51 +0100
From: Justin Iurman <justin.iurman@...ege.be>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski
 <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Shuah Khan <shuah@...nel.org>,
 David Ahern <dsahern@...nel.org>, linux-kselftest@...r.kernel.org,
 Po-Hsu Lin <po-hsu.lin@...onical.com>, Guillaume Nault <gnault@...hat.com>,
 Petr Machata <petrm@...dia.com>, James Prestwood <prestwoj@...il.com>,
 Jaehee Park <jhpark1013@...il.com>, Ido Schimmel <idosch@...dia.com>,
 Francesco Ruggeri <fruggeri@...sta.com>, Xin Long <lucien.xin@...il.com>,
 justin.iurman@...ege.be
Subject: Re: [PATCHv2 net-next 10/14] selftests/net: convert ioam6.sh to run
 it in unique namespace

On 11/30/23 05:01, Hangbin Liu wrote:
> Here is the test result after conversion.
> 
> ]# ./ioam6.sh
> 
> --------------------------------------------------------------------------
> OUTPUT tests
> --------------------------------------------------------------------------
> TEST: Unknown IOAM namespace (inline mode)                          [ OK ]
> TEST: Unknown IOAM namespace (encap mode)                           [ OK ]
> TEST: Missing trace room (inline mode)                              [ OK ]
> TEST: Missing trace room (encap mode)                               [ OK ]
> TEST: Trace type with bit 0 only (inline mode)                      [ OK ]
> ...
> TEST: Full supported trace (encap mode)                             [ OK ]
> 
> --------------------------------------------------------------------------
> GLOBAL tests
> --------------------------------------------------------------------------
> TEST: Forward - Full supported trace (inline mode)                  [ OK ]
> TEST: Forward - Full supported trace (encap mode)                   [ OK ]
> 
> - Tests passed: 88
> - Tests failed: 0
> 
> Acked-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Reviewed-by: Justin Iurman <justin.iurman@...ege.be>

LGTM. Just one question though. Is there any reason not to use 
cleanup_ns everywhere? There is the following diff (actually, 3 times):

> -    ip netns del ioam-tmp-node || true
> +    ip netns del $ioam_tmp_node || true

While, at the same time, there is the following diff (as expected):

> -  ip netns del ioam-node-alpha || true
> -  ip netns del ioam-node-beta || true
> -  ip netns del ioam-node-gamma || true
> +  cleanup_ns $ioam_node_alpha $ioam_node_beta $ioam_node_gamma

IMO, it looks like cleanup_ns can safely replace all "ip netns del" 
instances in ioam6.sh.