netdev - Re: [PATCHv2] USB: gl620a: check for rx buffer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 Nov 2023 16:42:57 +0000
From: Simon Horman <horms@...nel.org>
To: Oliver Neukum <oneukum@...e.com>
Cc: Sergei Shtylyov <sergei.shtylyov@...il.com>,
	Sergey Shtylyov <s.shtylyov@....ru>, dmitry.bezrukov@...antia.com,
	marcinguy@...il.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCHv2] USB: gl620a: check for rx buffer overflow

On Thu, Nov 30, 2023 at 10:38:09AM +0100, Oliver Neukum wrote:
> On 24.11.23 12:53, Simon Horman wrote:
> > 
> > 
> > I think it would be useful to include information along the lines
> > of the above in the patch description.
> 
> Hi,
> 
> I see why you want this information to be available.
> So I thought about it and I think this should be
> either in Documentation or in a comment in usbnet,
> so that new drivers include the necessary checks
> from the start. What do you think?

Hi Oliver,

yes, now you mention it that does seem appropriate.
And I don't think that doing so gates this patch.

Reviewed-by: Simon Horman <horms@...nel.org>

-- 
pw-bot: under-review