netdev - Re: [patch net-next] docs: netlink: add NLMSG_DONE message format for doit actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZWmQfH1VSP3ySNX0@nanopsycho>
Date: Fri, 1 Dec 2023 08:51:24 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, davem@...emloft.net,
	edumazet@...gle.com, corbet@....net
Subject: Re: [patch net-next] docs: netlink: add NLMSG_DONE message format
 for doit actions

Thu, Nov 30, 2023 at 06:39:39PM CET, kuba@...nel.org wrote:
>On Thu, 30 Nov 2023 14:30:36 +0100 Jiri Pirko wrote:
>> >connector is a really bad example, the doc would have to say "some
>> >families use NLMSG_DONE as an actual message type which may have pretty
>> >much anything attached to it". It's not worth it, sorry.  
>> 
>> The existing documentation confuses uapi users (I have sample).
>> They expect error with NLMSG_DONE.
>
>I hate this so much.

Unfortunatelly, Netlink has a lot of burden of misuse...


>
>How about we say:
>
>  Note that some families may issue custom NLMSG_DONE messages,
>  in which case the payload is implementation-specific.

I'm fine with that. Will send v2.