netdev - Re: [Intel-wired-lan] [PATCH iwl-next v1] idpf: refactor some missing field get/prep conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <266d7d7a-06a2-6d76-e17a-70d37abb04c9@intel.com>
Date: Fri, 1 Dec 2023 08:52:24 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, <anthony.l.nguyen@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] idpf: refactor some missing
 field get/prep conversions

On 11/30/23 22:45, Jesse Brandeburg wrote:
> Most of idpf correctly uses FIELD_GET and FIELD_PREP, but a couple spots
> were missed so fix those.
> 
> This conversion was automated via a coccinelle script as posted with the
> previous series.

[1]

> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
> This patch should be applied after the larger FIELD_PREP/FIELD_GET
> conversion series for the Intel drivers.

or at the end of,
so [1] would be self-explanatory

> ---
>   .../ethernet/intel/idpf/idpf_singleq_txrx.c    |  7 +++----
>   drivers/net/ethernet/intel/idpf/idpf_txrx.c    | 18 ++++++++----------
>   2 files changed, 11 insertions(+), 14 deletions(-)
> 

Anyway,
it is better code so,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>