netdev - Re: [PATCH iwl-next] ice: ice_base.c: Add const modifier to params and vars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231201095848.GT32077@kernel.org>
Date: Fri, 1 Dec 2023 09:58:48 +0000
From: Simon Horman <horms@...nel.org>
To: Jan Glaza <jan.glaza@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Andrii Staikov <andrii.staikov@...el.com>,
	Sachin Bahadur <sachin.bahadur@...el.com>
Subject: Re: [PATCH iwl-next] ice: ice_base.c: Add const modifier to params
 and vars

On Wed, Nov 29, 2023 at 02:36:11AM -0500, Jan Glaza wrote:
> Add const modifier to function parameters and variables where appropriate
> in ice_base.c and corresponding declarations in ice_base.h.
> 
> The reason for starting the change is that read-only pointers should be
> marked as const when possible to allow for smoother and more optimal code
> generation and optimization as well as allowing the compiler to warn the
> developer about potentially unwanted modifications, while not carrying
> noticable negative impact.

Hi Jan,

it's probably not worth respinning for this, but: noticeable

> 
> Reviewed-by: Andrii Staikov <andrii.staikov@...el.com>
> Reviewed-by: Sachin Bahadur <sachin.bahadur@...el.com>
> Signed-off-by: Jan Glaza <jan.glaza@...el.com>
> ---
> This change is done in one file to get comment feedback and, if positive,
> will be rolled out across the entire ice driver code.

The nit above notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@...nel.org>