netdev - Re: [PATCH net-next v6 1/4] page_pool: Rename pp_frag_count to pp_ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC_iWjKBE5s9iiTPKgsoDx5LSWjsSXE-7SSPSk+EVJXLC10-GQ@mail.gmail.com>
Date: Fri, 1 Dec 2023 12:10:10 +0200
From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
To: Liang Chen <liangchen.linux@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, hawk@...nel.org, linyunsheng@...wei.com, 
	netdev@...r.kernel.org, linux-mm@...ck.org, jasowang@...hat.com
Subject: Re: [PATCH net-next v6 1/4] page_pool: Rename pp_frag_count to pp_ref_count

re-sending as plain-text, apologize for the noise...

On Fri, 1 Dec 2023 at 11:59, Ilias Apalodimas
<ilias.apalodimas@...aro.org> wrote:
>
> Hi Liang,
>
> On Thu, 30 Nov 2023 at 13:59, Liang Chen <liangchen.linux@...il.com> wrote:
>>
>> To support multiple users referencing the same fragment, pp_frag_count is
>> renamed to pp_ref_count to better reflect its actual meaning based on the
>> suggestion from [1].

The patch does more than what the description says and those should be
in 2 different patches.
I am ok with pp_frag_count -> pp_ref_count, for the functions I am not
sure the rename makes anything better.

Jakub, are you ok with the name changes or is it going to make bisecting a pain?

Thanks
/Ilias