lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAC_iWj+ku5Mk99ezVdC4HhNWK=Ea83Ps-qaQq=_-fzVoWZ8sYQ@mail.gmail.com> Date: Fri, 1 Dec 2023 12:34:50 +0200 From: Ilias Apalodimas <ilias.apalodimas@...aro.org> To: Liang Chen <liangchen.linux@...il.com> Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, hawk@...nel.org, linyunsheng@...wei.com, netdev@...r.kernel.org, linux-mm@...ck.org, jasowang@...hat.com Subject: Re: [PATCH net-next v6 4/4] skbuff: Optimization of SKB coalescing for page pool HI Liang, [...] > } > > +/** > + * skb_pp_frag_ref() - Increase fragment reference count of a page > + * @page: page of the fragment on which to increase a reference > + * > + * Increase fragment reference count (pp_ref_count) on a page, but if it is > + * not a page pool page, fallback to increase a reference(_refcount) on a > + * normal page. > + */ > +static void skb_pp_frag_ref(struct page *page) > +{ > + struct page *head_page = compound_head(page); > + > + if (likely(skb_frag_is_pp_page(head_page))) > + page_pool_ref_page(head_page); > + else > + page_ref_inc(head_page); I think I've mentioned this in the past, but I think shoehorning page pool awareness in the skbuff is not the direction we want to go. Up to now, we've tried hard to make that as seamless as possible. The code looks correct, but I'd prefer people with a better understanding of the core network stack to comment on this. [...] Thanks /Ilias
Powered by blists - more mailing lists