netdev - Re: [PATCH net-next v1] octeon_ep: control net API framework to support offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231201195843.118fdcfe@kernel.org>
Date: Fri, 1 Dec 2023 19:58:43 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Shinas Rasheed <srasheed@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <hgani@...vell.com>, <vimleshk@...vell.com>, <egallen@...hat.com>,
 <mschmidt@...hat.com>, <pabeni@...hat.com>, <horms@...nel.org>,
 <davem@...emloft.net>, <wizhao@...hat.com>, <konguyen@...hat.com>,
 "Veerasenareddy Burru" <vburru@...vell.com>, Sathesh Edara
 <sedara@...vell.com>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v1] octeon_ep: control net API framework to
 support offloads

On Fri, 1 Dec 2023 05:18:14 -0800 Shinas Rasheed wrote:
> +static netdev_features_t octep_fix_features(struct net_device *dev,
> +					    netdev_features_t features)
> +{
> +	return (dev->hw_features & features);
> +}

Why is this needed? The core kernel should already make sure
unsupported features aren't requested.