netdev - RE: [EXT] Re: [PATCH net-next v1] octeon_ep: control net API framework to support offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: 
 <PH0PR18MB4734DF93FA905F7160AAE23EC786A@PH0PR18MB4734.namprd18.prod.outlook.com>
Date: Mon, 4 Dec 2023 06:39:14 +0000
From: Shinas Rasheed <srasheed@...vell.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Haseeb Gani
	<hgani@...vell.com>, Vimlesh Kumar <vimleshk@...vell.com>,
        "egallen@...hat.com" <egallen@...hat.com>,
        "mschmidt@...hat.com"
	<mschmidt@...hat.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "horms@...nel.org" <horms@...nel.org>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "wizhao@...hat.com" <wizhao@...hat.com>,
        "konguyen@...hat.com" <konguyen@...hat.com>,
        Veerasenareddy Burru
	<vburru@...vell.com>,
        Sathesh B Edara <sedara@...vell.com>,
        Eric Dumazet
	<edumazet@...gle.com>
Subject: RE: [EXT] Re: [PATCH net-next v1] octeon_ep: control net API
 framework to support offloads



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Saturday, December 2, 2023 9:29 AM
> To: Shinas Rasheed <srasheed@...vell.com>
> > +static netdev_features_t octep_fix_features(struct net_device *dev,
> > +					    netdev_features_t features)
> > +{
> > +	return (dev->hw_features & features);
> > +}
> 
> Why is this needed? The core kernel should already make sure
> unsupported features aren't requested.

Yes that is correct. I also don't see an interdependency between features to decide anything in this function currently, so I think perhaps fix features can be implemented later on or even just return the obtained features itself I guess. I'll submit an updated patch set. Any other nits to update in the next version?