netdev - Re: [Intel-wired-lan] [PATCH iwl-next v1 08/13] igc: field prep conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c55d299b-ff6b-4da6-bc9f-931d7cd5b2f8@linux.intel.com>
Date: Tue, 5 Dec 2023 13:16:41 +0200
From: "naamax.meir" <naamax.meir@...ux.intel.com>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>,
 intel-wired-lan@...ts.osuosl.org
Cc: Julia Lawall <Julia.Lawall@...ia.fr>, netdev@...r.kernel.org,
 Sasha Neftin <sasha.neftin@...el.com>,
 Marcin Szycik <marcin.szycik@...ux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 08/13] igc: field prep
 conversion

On 11/21/2023 23:19, Jesse Brandeburg wrote:
> Refactor igc driver to use FIELD_PREP(), which reduces lines of code
> and adds clarity of intent.
> 
> This code was generated by the following coccinelle/spatch script and
> then manually repaired in a later patch.
> 
> @prep@
> constant shift,mask;
> expression a;
> @@
> -((a << shift) & mask)
> +FIELD_PREP(mask, a)
> 
> Cc: Julia Lawall <Julia.Lawall@...ia.fr>
> Cc: Sasha Neftin <sasha.neftin@...el.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Naama Meir <naamax.meir@...ux.intel.com>