netdev - Re: [Intel-wired-lan] [PATCH iwl-next v1 10/13] igc: field get conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41a1392c-0e82-4906-8744-fd527d18f6aa@linux.intel.com>
Date: Wed, 6 Dec 2023 10:22:21 +0200
From: "naamax.meir" <naamax.meir@...ux.intel.com>
To: Jesse Brandeburg <jesse.brandeburg@...el.com>,
 intel-wired-lan@...ts.osuosl.org
Cc: Julia Lawall <Julia.Lawall@...ia.fr>, netdev@...r.kernel.org,
 Marcin Szycik <marcin.szycik@...ux.intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 10/13] igc: field get
 conversion

On 11/21/2023 23:19, Jesse Brandeburg wrote:
> Refactor the igc driver to use FIELD_GET() for mask and shift reads,
> which reduces lines of code and adds clarity of intent.
> 
> This code was generated by the following coccinelle/spatch script and
> then manually repaired in a later patch.
> 
> @get@
> constant shift,mask;
> expression a;
> @@
> -((a & mask) >> shift)
> +FIELD_GET(mask, a)
> 
> and applied via:
> spatch --sp-file field_prep.cocci --in-place --dir \
>   drivers/net/ethernet/intel/
> 
> Cc: Julia Lawall <Julia.Lawall@...ia.fr>
> Reviewed-by: Marcin Szycik <marcin.szycik@...ux.intel.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_base.c | 6 ++----
>   drivers/net/ethernet/intel/igc/igc_i225.c | 5 ++---
>   drivers/net/ethernet/intel/igc/igc_main.c | 6 ++----
>   drivers/net/ethernet/intel/igc/igc_phy.c  | 4 ++--
>   4 files changed, 8 insertions(+), 13 deletions(-)

Tested-by: Naama Meir <naamax.meir@...ux.intel.com>