netdev - Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B0DA4901-0C2F-4D4D-966F-BF89C67219DD@geanix.com>
Date: Wed, 6 Dec 2023 10:00:52 +0100
From: Sean Nyekjaer <sean@...nix.com>
To: Arun.Ramadoss@...rochip.com
Cc: Woojung.Huh@...rochip.com,
 UNGLinuxDriver@...rochip.com,
 andrew@...n.ch,
 f.fainelli@...il.com,
 olteanv@...il.com,
 davem@...emloft.net,
 edumazet@...gle.com,
 kuba@...nel.org,
 pabeni@...hat.com,
 netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without _VALUE
 define

Hi Arun,

> On 6 Dec 2023, at 09.58, <Arun.Ramadoss@...rochip.com> <Arun.Ramadoss@...rochip.com> wrote:
> 
> Hi Sean,
> 
>> -----Original Message-----
>> From: Sean Nyekjaer <sean@...nix.com>
>> Sent: Wednesday, December 6, 2023 12:55 PM
>> To: Woojung Huh - C21699 <Woojung.Huh@...rochip.com>;
>> UNGLinuxDriver <UNGLinuxDriver@...rochip.com>; Andrew Lunn
>> <andrew@...n.ch>; Florian Fainelli <f.fainelli@...il.com>; Vladimir Oltean
>> <olteanv@...il.com>; David S. Miller <davem@...emloft.net>; Eric
>> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
>> Paolo Abeni <pabeni@...hat.com>; Arun Ramadoss - I17769
>> <Arun.Ramadoss@...rochip.com>
>> Cc: Sean Nyekjaer <sean@...nix.com>; netdev@...r.kernel.org; linux-
>> kernel@...r.kernel.org
>> Subject: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
>> _VALUE define
>> 
>> [Some people who received this message don't often get email from
>> sean@...nix.com. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>> 
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>> 
>> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
>> DSA_TAG_PROTO_LAN937X to improve readability.
>> 
>> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
>> Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> 
> Not sure, whether it is a bug fix or not. Since it only improves readability.
> I believe it should point to net-next. 
> 

Agree :)

Feel free to remove the Fixes tag while applying.

/Sean