netdev - Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231206155818.p5ll7au2mwqipvf3@skbuf>
Date: Wed, 6 Dec 2023 17:58:18 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Sean Nyekjaer <sean@...nix.com>
Cc: Arun.Ramadoss@...rochip.com, Woojung.Huh@...rochip.com,
	UNGLinuxDriver@...rochip.com, andrew@...n.ch, f.fainelli@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: microchip: use DSA_TAG_PROTO without
 _VALUE define

On Wed, Dec 06, 2023 at 10:00:52AM +0100, Sean Nyekjaer wrote:
> Hi Arun,
> 
> > On 6 Dec 2023, at 09.58, <Arun.Ramadoss@...rochip.com> <Arun.Ramadoss@...rochip.com> wrote:
> > 
> > Hi Sean,
> > 
> >> -----Original Message-----
> >> Correct the use of define DSA_TAG_PROTO_LAN937X_VALUE to
> >> DSA_TAG_PROTO_LAN937X to improve readability.
> >> 
> >> Fixes: 99b16df0cd52 ("net: dsa: microchip: lan937x: add dsa_tag_protocol")
> >> Signed-off-by: Sean Nyekjaer <sean@...nix.com>
> > 
> > Not sure, whether it is a bug fix or not. Since it only improves readability.
> > I believe it should point to net-next. 
> > 
> 
> Agree :)
> 
> Feel free to remove the Fixes tag while applying.
> 
> /Sean

If you're talking to Arun: he can't do that. Only Jakub, David, Paolo
and Eric can apply patches, and based on history, I don't think that
either of them is keen on editing patches before applying. One way or
another, based on past experience, you might be better off just resending,
with the Fixes tag dropped, and patch retargeted to net-next (and
counter incremented to v2).

The criteria from Documentation/process/stable-kernel-rules.rst still
apply pretty much to net.git as well, since these patches land in stable
trees too. We triage as much as possible, to give users of stable
kernels a worthwhile reason to update, not a change that results in
absolutely the same generated machine code.