netdev - Re: [PATCH net-next v3 2/7] net: wangxun: unified phylink implementation in libwx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXBl8VCncGJSpkad@shell.armlinux.org.uk>
Date: Wed, 6 Dec 2023 12:15:45 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew@...n.ch, netdev@...r.kernel.org,
	mengyuanlou@...-swift.com
Subject: Re: [PATCH net-next v3 2/7] net: wangxun: unified phylink
 implementation in libwx

On Wed, Dec 06, 2023 at 05:53:50PM +0800, Jiawen Wu wrote:
> Use wx->phylink instead of txgbe->phylink, and move the same ethtool
> functions to libwx because them can be implemented with phylink in
> ngbe driver.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@...stnetic.com>

I would probably do the first two patches of your series differently:

Patch 1: add struct phylink + phylink_config to the wx structure, and
  add the helper functions for ksettings and nway reset.

Patch 2: convert txgbe to use the bits added in patch 1.

Patch 3: convert ngbe to phylink using the wx bits added in the first
  patch as a pure phylink conversion.

Patch 4: change how the PHY is attached/detached (as mentioned in the
  review of your existing first patch.)

which probably would have been easier to review.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!