netdev - Re: [PATCH net-next v7 2/2] net: dsa: microchip: add property to select internal RMII reference clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ce63acd-576d-479f-847a-9528c915d64f@lunn.ch>
Date: Wed, 6 Dec 2023 16:39:23 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Ante Knezic <ante.knezic@...mholz.de>
Cc: netdev@...r.kernel.org, woojung.huh@...rochip.com, f.fainelli@...il.com,
	olteanv@...il.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	marex@...x.de, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v7 2/2] net: dsa: microchip: add property to
 select internal RMII reference clock

On Tue, Dec 05, 2023 at 11:03:39AM +0100, Ante Knezic wrote:
> Microchip KSZ8863/KSZ8873 have the ability to select between internal
> and external RMII reference clock. By default, reference clock
> needs to be provided via REFCLKI_3 pin. If required, device can be
> setup to provide RMII clock internally so that REFCLKI_3 pin can be
> left unconnected.
> Add a new "microchip,rmii-clk-internal" property which will set
> RMII clock reference to internal. If property is not set, reference
> clock needs to be provided externally.
> 
> While at it, move the ksz8795_cpu_interface_select() to
> ksz8_config_cpu_port() to get a cleaner call path for cpu port.
> 
> Signed-off-by: Ante Knezic <ante.knezic@...mholz.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew