netdev - RE: [PATCH net-next v8 1/8] net: ethtool: pass a pointer to parameters to get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82af13c02b5b4a3b9372ee5b38221b4b@amazon.com>
Date: Thu, 7 Dec 2023 07:02:28 +0000
From: "Kiyanovski, Arthur" <akiyano@...zon.com>
To: Ahmed Zaki <ahmed.zaki@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"corbet@....net" <corbet@....net>, "jesse.brandeburg@...el.com"
	<jesse.brandeburg@...el.com>, "anthony.l.nguyen@...el.com"
	<anthony.l.nguyen@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"vladimir.oltean@....com" <vladimir.oltean@....com>, "andrew@...n.ch"
	<andrew@...n.ch>, "horms@...nel.org" <horms@...nel.org>, "mkubecek@...e.cz"
	<mkubecek@...e.cz>, "willemdebruijn.kernel@...il.com"
	<willemdebruijn.kernel@...il.com>, "gal@...dia.com" <gal@...dia.com>,
	"alexander.duyck@...il.com" <alexander.duyck@...il.com>,
	"ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, Jacob Keller
	<jacob.e.keller@...el.com>
Subject: RE: [PATCH net-next v8 1/8] net: ethtool: pass a pointer to parameters to
 get/set_rxfh ethtool ops


> The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters
> as direct function arguments. This will force us to change the API (and
> all drivers' functions) every time some new parameters are added.
> 
> This is part 1/2 of the fix, as suggested in [1]:
> 
> - First simplify the code by always providing a pointer to all params
>    (indir, key and func); the fact that some of them may be NULL seems
>    like a weird historic thing or a premature optimization.
>    It will simplify the drivers if all pointers are always present.
> 
>  - Then make the functions take a dev pointer, and a pointer to a
>    single struct wrapping all arguments. The set_* should also take
>    an extack.
> 
> Link: https://lore.kernel.org/netdev/20231121152906.2dd5f487@kernel.org/
> [1]
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Suggested-by: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> ---

Thanks for submitting this.
For the ENA driver:
Acked-by: Arthur Kiyanovski <akiyano@...zon.com>