netdev - Re: [PATCH iwl-net v3] i40e: Restore VF MSI-X state during PCI reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 7 Dec 2023 10:34:12 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Andrii Staikov <andrii.staikov@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Karen Ostrowska <karen.ostrowska@...el.com>,
	Mateusz Palczewski <mateusz.palczewski@...el.com>, Drewek Wojciech
	<wojciech.drewek@...el.com>
Subject: Re: [PATCH iwl-net v3] i40e: Restore VF MSI-X state during PCI reset

On 12/6/23 13:51, Andrii Staikov wrote:
> During a PCI FLR the MSI-X Enable flag in the VF PCI MSI-X capability
> register will be cleared. This can lead to issues when a VF is
> assigned to a VM because in these cases the VF driver receives no
> indication of the PF PCI error/reset and additionally it is incapable
> of restoring the cleared flag in the hypervisor configuration space
> without fully reinitializing the driver interrupt functionality.
> 
> Since the VF driver is unable to easily resolve this condition on its own,
> restore the VF MSI-X flag during the PF PCI reset handling.
> 
> Fixes: 19b7960b2da1 ("i40e: implement split PCI error reset handler")
> Co-developed-by: Karen Ostrowska <karen.ostrowska@...el.com>
> Signed-off-by: Karen Ostrowska <karen.ostrowska@...el.com>
> Co-developed-by: Mateusz Palczewski <mateusz.palczewski@...el.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@...el.com> > Reviewed-by: Drewek Wojciech <wojciech.drewek@...el.com>

It's good that you pass tags from our e1000 ML here,
however please copy them verbatim from the response body (instead of
copying that from whatever MS outlook displays as sender).
(Wojtek's RB was fine in previous version of the patch)

> Reviewed-by: Kitszel Przemyslaw <przemyslaw.kitszel@...el.com>

You should never add such tags when not explicitly provided by reviewer.

> Signed-off-by: Andrii Staikov <andrii.staikov@...el.com>
> ---
> v1 -> v2: Fix signed-off tags
> v2 -> v3: use @vf_dev in pci_get_device() instead of NULL and
> remove unnecessary call

Thank you, code looks fine now.

> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c   |  2 ++
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.c    | 24 +++++++++++++++++++
>   .../ethernet/intel/i40e/i40e_virtchnl_pf.h    |  1 +
>   3 files changed, 27 insertions(+)
Assuming you will fix RB tags:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>