netdev - Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: Restore VF MSI-X state during PCI reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202312080413.jtUlijX8-lkp@intel.com>
Date: Fri, 8 Dec 2023 04:33:31 +0800
From: kernel test robot <lkp@...el.com>
To: Andrii Staikov <andrii.staikov@...el.com>,
	intel-wired-lan@...ts.osuosl.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Drewek Wojciech <wojciech.drewek@...el.com>,
	Karen Ostrowska <karen.ostrowska@...el.com>, netdev@...r.kernel.org,
	Andrii Staikov <andrii.staikov@...el.com>,
	Mateusz Palczewski <mateusz.palczewski@...el.com>,
	Kitszel Przemyslaw <przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3] i40e: Restore VF MSI-X
 state during PCI reset

Hi Andrii,

kernel test robot noticed the following build errors:

[auto build test ERROR on tnguy-net-queue/dev-queue]

url:    https://github.com/intel-lab-lkp/linux/commits/Andrii-Staikov/i40e-Restore-VF-MSI-X-state-during-PCI-reset/20231206-205526
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
patch link:    https://lore.kernel.org/r/20231206125127.218350-1-andrii.staikov%40intel.com
patch subject: [Intel-wired-lan] [PATCH iwl-net v3] i40e: Restore VF MSI-X state during PCI reset
config: powerpc-ppc64_defconfig (https://download.01.org/0day-ci/archive/20231208/202312080413.jtUlijX8-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231208/202312080413.jtUlijX8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312080413.jtUlijX8-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function 'i40e_restore_all_vfs_msi_state':
>> drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:175:58: error: 'struct pci_dev' has no member named 'physfn'; did you mean 'is_physfn'?
     175 |                         if (vf_dev->is_virtfn && vf_dev->physfn == pdev)
         |                                                          ^~~~~~
         |                                                          is_physfn


vim +175 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

   156	
   157	void i40e_restore_all_vfs_msi_state(struct pci_dev *pdev)
   158	{
   159		u16 vf_id;
   160		u16 pos;
   161	
   162		/* Continue only if this is a PF */
   163		if (!pdev->is_physfn)
   164			return;
   165	
   166		if (!pci_num_vf(pdev))
   167			return;
   168	
   169		pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_SRIOV);
   170		if (pos) {
   171			struct pci_dev *vf_dev = NULL;
   172	
   173			pci_read_config_word(pdev, pos + PCI_SRIOV_VF_DID, &vf_id);
   174			while ((vf_dev = pci_get_device(pdev->vendor, vf_id, vf_dev))) {
 > 175				if (vf_dev->is_virtfn && vf_dev->physfn == pdev)
   176					pci_restore_msi_state(vf_dev);
   177			}
   178		}
   179	}
   180	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki