netdev - Re: [PATCH net v2 3/4] bnxt_en: Fix wrong return value check in bnxt_close

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231207143102.049820a2@kernel.org>
Date: Thu, 7 Dec 2023 14:31:02 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Michael Chan <michael.chan@...adcom.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, gospo@...adcom.com, Kalesh AP
 <kalesh-anakkur.purayil@...adcom.com>, Vikas Gupta
 <vikas.gupta@...adcom.com>, Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net v2 3/4] bnxt_en: Fix wrong return value check in
 bnxt_close_nic()

On Thu, 7 Dec 2023 14:24:24 -0800 Michael Chan wrote:
> The code will always proceed to do the close when
> wait_event_interruptible_timeout() returns for any reason.  The check
> is just to log a warning message that the wait has timed out and we're
> closing anyway.
> 
> What I can do is to log another warning if the wait is interrupted by
> a signal.  Since we do the close no matter what, the error code should
> not be returned to the caller and the function should be changed to
> void.  Does that sound reasonable?

Yup!