netdev - Re: [net-next 2/2] net: dsa: realtek: load switch variants on demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231207223143.doivjphfgs4sfvx6@skbuf>
Date: Fri, 8 Dec 2023 00:31:43 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: Alvin Šipraga <ALSI@...g-olufsen.dk>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"andrew@...n.ch" <andrew@...n.ch>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"arinc.unal@...nc9.com" <arinc.unal@...nc9.com>
Subject: Re: [net-next 2/2] net: dsa: realtek: load switch variants on demand

On Thu, Dec 07, 2023 at 04:50:12PM -0300, Luiz Angelo Daros de Luca wrote:
> HI Vladmir,
> 
> We discussed something about that in the past:
> 
> https://lkml.kernel.org/netdev/20220630200423.tieprdu5fpabflj7@bang-olufsen.dk/T/#m04e6cf7d0c1f18b02c2bf40266ada915b1f02f3d
> 
> The code is able to handle only a single node and binding docs say it
> should be named "mdio". The compatible string wasn't a requirement
> since the beginning and I don't think it is worth it to rename the
> compatible string. I suggest we simply switch to
> of_get_child_by_name() and look for a node named "mdio". If that node
> is not found, we can still look for the old compatible string
> (backwards compatibility) and probably warn the "user" (targeting not
> the end-user but the one creating the DT for a new device).
> 
> I don't know how to handle the binding docs as the compatible string
> is still a requirement for older kernel versions. Is it ok to update
> the device-tree bindings docs in such a way it would break old
> drivers? Or should we keep it there until the last LTS kernel
> requiring it reaches EOL? As device-tree bindings docs should not
> consider how the driver was implemented, I think it would be strange
> to have a note like "required by kernel up to 6.x".
> 
> Regards,
> 
> Luiz

And did you ever answer this question?

"And why do you even need to remove the compatible string from the MDIO
node, can't you just ignore it, does it bother you in any way?"

I'm very confused as to what you're after.