netdev - Re: [PATCH v4 iwl-next] i40e: Use correct buffer size in i40e_dbg_command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92e5cc01-e8b3-b6d2-e884-3d6bd001f0d0@intel.com>
Date: Thu, 7 Dec 2023 15:25:47 -0800
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Alexander Lobakin <aleksander.lobakin@...el.com>, Kunwu Chan
	<chentao@...inos.cn>
CC: <jesse.brandeburg@...el.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<jeffrey.t.kirsher@...el.com>, <shannon.nelson@....com>,
	<kunwu.chan@...mail.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Simon Horman <horms@...nel.org>
Subject: Re: [PATCH v4 iwl-next] i40e: Use correct buffer size in
 i40e_dbg_command_read



On 12/6/2023 4:40 AM, Alexander Lobakin wrote:
> From: Kunwu Chan <chentao@...inos.cn>
> Date: Tue, 5 Dec 2023 17:58:44 +0800
> 
>> The size of "i40e_dbg_command_buf" is 256, the size of "name"
>> depends on "IFNAMSIZ", plus a null character and format size,
>> the total size is more than 256.
>>
>> Improve readability and maintainability by replacing a hardcoded string
>> allocation and formatting by the use of the kasprintf() helper.
>>
>> Fixes: 02e9c290814c ("i40e: debugfs interface")
>> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
>> Suggested-by: Simon Horman <horms@...nel.org>
>> Suggested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> Your Signed-off-by must be the last tag in the block.
> Perhaps the maintainer could fix it when taking, so that you wouldn't
> need to send a new version only due to that.

You missed Intel Wired LAN (intel-wired-lan@...ts.osuosl.org) on this, 
though the other versions did have it. Could you fix this up and be sure 
to include Intel Wired LAN?

Thanks,
Tony

>> ---
>> v2
>>     - Update the size calculation with IFNAMSIZ and sizeof(i40e_dbg_command_buf)
>> v3
>>     - Use kasprintf to improve readability and maintainability
>> v4
>>     - Fix memory leak in error path