lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <170206026051.2485962.13304186324857333888.robh@kernel.org> Date: Fri, 08 Dec 2023 12:31:00 -0600 From: Rob Herring <robh@...nel.org> To: Conor Dooley <conor@...nel.org> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh+dt@...nel.org>, Stephen Boyd <sboyd@...nel.org>, Jakub Kicinski <kuba@...nel.org>, linux-can@...r.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Paul Walmsley <paul.walmsley@...ive.com>, Albert Ou <aou@...s.berkeley.edu>, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, Daire McNamara <daire.mcnamara@...rochip.com>, Wolfgang Grandegger <wg@...ndegger.com>, Conor Dooley <conor.dooley@...rochip.com>, linux-riscv@...ts.infradead.org, Eric Dumazet <edumazet@...gle.com>, Marc Kleine-Budde <mkl@...gutronix.de>, Palmer Dabbelt <palmer@...belt.com>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH RESEND v1 2/7] dt-bindings: can: mpfs: add missing required clock On Fri, 08 Dec 2023 17:12:24 +0000, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@...rochip.com> > > The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a > CAN bus clock. The bus clock was omitted when the binding was written, > but is required for operation. Make up for lost time and add it. > > Cautionary tale in adding bindings without having implemented a real > user for them perhaps. > > Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller") > Signed-off-by: Conor Dooley <conor.dooley@...rochip.com> > --- > .../devicetree/bindings/net/can/microchip,mpfs-can.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml: properties:clocks: {'maxItems': 2, 'items': [{'description': 'AHB peripheral clock'}, {'description': 'CAN bus clock'}]} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231208-palpitate-passable-c79bacf2036c@spud The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists