netdev - Re: [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst files if ynl-gen-rst changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m21qbq780z.fsf@gmail.com>
Date: Wed, 13 Dec 2023 09:42:52 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Breno Leitao <leitao@...ian.org>
Cc: netdev@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,  "David S.
 Miller" <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo
 Abeni <pabeni@...hat.com>,  Jonathan Corbet <corbet@....net>,
  linux-doc@...r.kernel.org,  Jacob Keller <jacob.e.keller@...el.com>,
  donald.hunter@...hat.com
Subject: Re: [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst
 files if ynl-gen-rst changes

Breno Leitao <leitao@...ian.org> writes:

>> +$(YNL_INDEX): $(YNL_RST_FILES) $(YNL_TOOL)
>> +	$(Q)$(YNL_TOOL) -o $@ -x
>
> Isn't $(YNL_INDEX) depending to $(YNL_TOOL) indirectly since it depends
> on $(YNL_RST_FILES) ?
>
> I mean, do you really need the line above?

Sure, the transitive dependency is sufficient. I tend to add an explicit
dependency for a script that gets run in a target.

Happy to remove that change and respin if you prefer?