netdev - Re: [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst files if ynl-gen-rst changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXnGglqz01BxAB21@gmail.com>
Date: Wed, 13 Dec 2023 06:58:10 -0800
From: Breno Leitao <leitao@...ian.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
	Jacob Keller <jacob.e.keller@...el.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v3 09/13] doc/netlink: Regenerate netlink .rst
 files if ynl-gen-rst changes

On Wed, Dec 13, 2023 at 09:42:52AM +0000, Donald Hunter wrote:
> Breno Leitao <leitao@...ian.org> writes:
> 
> >> +$(YNL_INDEX): $(YNL_RST_FILES) $(YNL_TOOL)
> >> +	$(Q)$(YNL_TOOL) -o $@ -x
> >
> > Isn't $(YNL_INDEX) depending to $(YNL_TOOL) indirectly since it depends
> > on $(YNL_RST_FILES) ?
> >
> > I mean, do you really need the line above?
> 
> Sure, the transitive dependency is sufficient. I tend to add an explicit
> dependency for a script that gets run in a target.
> 
> Happy to remove that change and respin if you prefer?

I would say it is preferred to remove unnecessary code.

Feel free to add the following line in the new version:

	Reviewed-by: Breno Leitao <leitao@...ian.org>

Thanks for addressing this.