netdev - Re: [PATCH net-next v3 3/3] net: sched: Add initial TC error skb drop reasons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56865ef2-2219-41e1-8ef4-116c56180786@mojatatu.com>
Date: Wed, 13 Dec 2023 15:25:33 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 daniel@...earbox.net, dcaratti@...hat.com, netdev@...r.kernel.org,
 kernel@...atatu.com
Subject: Re: [PATCH net-next v3 3/3] net: sched: Add initial TC error skb drop
 reasons



On 11/12/2023 23:30, Jakub Kicinski wrote:
> On Tue,  5 Dec 2023 17:50:30 -0300 Victor Nogueira wrote:
>> +	/**
>> +	 * @SKB_DROP_REASON_TC_EXT_COOKIE_NOTFOUND: tc cookie was looked up
>> +	 * using ext, but was not found.
>> +	 */
>> +	SKB_DROP_REASON_TC_EXT_COOKIE_NOTFOUND,
>> +	/**
>> +	 * @SKB_DROP_REASON_TC_COOKIE_EXT_MISMATCH: tc ext was lookup using
>> +	 * cookie and either was not found or different from expected.
>> +	 */
>> +	SKB_DROP_REASON_TC_COOKIE_EXT_MISMATCH,
>> +	/**
>> +	 * @SKB_DROP_REASON_TC_COOKIE_MISMATCH: tc cookie available but was
>> +	 * unable to match to filter.
>> +	 */
>> +	SKB_DROP_REASON_TC_COOKIE_MISMATCH,
> 
> Do we really need 3 reasons for COOKIE?
> 
> Also cookie here is offload state thing right? I wonder how many admins
> / SREs would be able to figure out what's going on based on this kdoc :S
> Let alone if it's a configuration problem or a race condition...

Yeah, probably overkill. Will merge into one.

cheers,
Victor