[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 12 Dec 2023 12:16:50 -0500
From: Jamal Hadi Salim <hadi@...atatu.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>, Jakub Kicinski <kuba@...nel.org>,
Victor Nogueira <victor@...atatu.com>, xiyou.wangcong@...il.com, jiri@...nulli.us,
davem@...emloft.net, pabeni@...hat.com, daniel@...earbox.net,
dcaratti@...hat.com, netdev@...r.kernel.org, kernel@...atatu.com
Subject: Re: [PATCH net-next v3 2/3] net: sched: Make tc-related drop reason
more flexible for remaining qdiscs
On Tue, Dec 12, 2023 at 11:57 AM 'Eric Dumazet' via kernel issues
<kernel@...atatu.com> wrote:
>
> On Tue, Dec 12, 2023 at 5:28 PM Jamal Hadi Salim <jhs@...atatu.com> wrote:
> >
>
> >
> > So when we looked at this code there was some mystery. It wasnt clear
> > how to_free could have more than one skb.
>
> Some qdisc can free skbs at enqueue() time in a batch for performance
> reason (fq_codel_drop() is such an instance)
Ok, makes more sense, should've caught that (there are others like taprio).
> I agree that all skbs in this list have probably the same drop_reason ?
It seems that way. We will review all the qdiscs to see if there's any
exceptions.
Thanks Eric.
cheers,
jamal
Powered by blists - more mailing lists