[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231214165618.GM5817@kernel.org>
Date: Thu, 14 Dec 2023 16:56:18 +0000
From: Simon Horman <horms@...nel.org>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: Jakub Kicinski <kuba@...nel.org>, edward.cree@....com,
linux-net-drivers@....com, davem@...emloft.net, pabeni@...hat.com,
edumazet@...gle.com, netdev@...r.kernel.org,
habetsm.xilinx@...il.com,
Jonathan Cooper <jonathan.s.cooper@....com>
Subject: Re: [PATCH net-next 7/7] sfc: add debugfs node for filter table
contents
On Wed, Dec 13, 2023 at 12:15:04PM +0000, Edward Cree wrote:
> On 12/12/2023 16:19, Jakub Kicinski wrote:
> > On Tue, 12 Dec 2023 15:14:17 +0000 Edward Cree wrote:
> >> I will update the commit message to call out and explain this; I
> >> believe the code is actually fine.
> >
> > Fair point, second time in a ~month we see this sort of false positive.
> > I'll throw [^\\]$ at the end of the regex to try to avoid matching stuff
> > that's most likely a macro.
>
> Sounds good, thanks.
>
> > This one looks legit tho:
> >
> > +void efx_debugfs_print_filter(char *s, size_t l, struct efx_filter_spec *spec) {}
>
> Yep, that one's real, will be fixed in v2.
> And this time I'll actually build-test with CONFIG_DEBUG_FS=n,
> which I forgot to do with v1 (sorry).
Thanks, and sorry for the false positives.
Also, I like coffee :)
>
> -ed
Powered by blists - more mailing lists