netdev - Re: [PATCH v2 net-next 01/12] tcp: Use bhash2 for v4-mapped-v6 non-wildcard address.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+cYcR51VHU0MsVyinWV4xNEHWdHt16sJTKmGRGMiK30Q@mail.gmail.com>
Date: Fri, 15 Dec 2023 15:03:31 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 01/12] tcp: Use bhash2 for v4-mapped-v6
 non-wildcard address.

On Wed, Dec 13, 2023 at 9:21 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> While checking port availability in bind() or listen(), we used only
> bhash for all v4-mapped-v6 addresses.  But there is no good reason not
> to use bhash2 for v4-mapped-v6 non-wildcard addresses.
>
> Let's do it by returning true in inet_use_bhash2_on_bind().  Then, we
> also need to add a test in inet_bind2_bucket_match_addr_any() so that
> ::ffff:X.X.X.X will match with 0.0.0.0.
>
> Note that sk->sk_rcv_saddr is initialised for v4-mapped-v6 sk in
> __inet6_bind().
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>