netdev - Re: [PATCH v2 net-next 03/12] tcp: Save v4 address as v4-mapped-v6 in inet_bind2_bucket.v6_rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLz+D6NTnNcX0WdXkMx5=c2yr9q6AP3gS7XYzYKYqrCnQ@mail.gmail.com>
Date: Fri, 15 Dec 2023 16:43:25 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 03/12] tcp: Save v4 address as v4-mapped-v6 in inet_bind2_bucket.v6_rcv_saddr.

On Wed, Dec 13, 2023 at 9:22 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> In bhash2, IPv4/IPv6 addresses are saved in two union members,
> which complicate address checks in inet_bind2_bucket_addr_match()
> and inet_bind2_bucket_match_addr_any() considering uninitialised
> memory and v4-mapped-v6 conflicts.
>
> Let's simplify that by saving IPv4 address as v4-mapped-v6 address
> and defining tb2.rcv_saddr as tb2.v6_rcv_saddr.s6_addr32[3].
>
> Then, we can compare v6 address as is, and after checking v4-mapped-v6,
> we can compare v4 address easily.  Also, we can remove tb2->family.
>
> Note these functions will be further refactored in the next patch.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>


Reviewed-by: Eric Dumazet <edumazet@...gle.com>