[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d63e8b6a-c0fc-4d99-b399-86f66f369176@linaro.org>
Date: Fri, 15 Dec 2023 16:48:35 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Christian Marangi <ansuelsmth@...il.com>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, Russell King
<linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [net-next PATCH v3 1/4] dt-bindings: net: phy: Document new LEDs
active-low property
On 13/12/2023 12:13, Christian Marangi wrote:
> Document new LEDs active-low property to define if the LED require to be
> set low to be turned on.
>
> active-low can be defined in the leds node for PHY that apply the LED
> polarity globally for each attached LED or in the specific led node for
> PHY that supports setting the LED polarity per LED.
>
> Declaring both way is not supported and will result in the schema
> getting rejected.
>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> ---
> Changes v3:
> - Out of RFC
> Changes v2:
> - Add this patch
>
> .../devicetree/bindings/net/ethernet-phy.yaml | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> index 8fb2a6ee7e5b..9cb3981fed2a 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> @@ -213,6 +213,11 @@ properties:
> '#size-cells':
> const: 0
>
> + 'active-low':
Drop quotes, no need for them.
As pointed out in other patchset, bool might not be enough.
https://lore.kernel.org/all/74cb1d1c-64b8-4fb0-9e6d-c2fad8417232@lunn.ch/
Anyway, both cases probably needs to be considered here.
Best regards,
Krzysztof
Powered by blists - more mailing lists