netdev - Re: [net-next PATCH v3 1/4] dt-bindings: net: phy: Document new LEDs active-low property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <657c8ec6.5d0a0220.4648c.58d2@mx.google.com>
Date: Fri, 15 Dec 2023 15:24:16 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	tobias Waldekranz <tobias@...dekranz.com>
Subject: Re: [net-next PATCH v3 1/4] dt-bindings: net: phy: Document new LEDs
 active-low property

On Fri, Dec 15, 2023 at 04:48:35PM +0100, Krzysztof Kozlowski wrote:
> On 13/12/2023 12:13, Christian Marangi wrote:
> > Document new LEDs active-low property to define if the LED require to be
> > set low to be turned on.
> > 
> > active-low can be defined in the leds node for PHY that apply the LED
> > polarity globally for each attached LED or in the specific led node for
> > PHY that supports setting the LED polarity per LED.
> > 
> > Declaring both way is not supported and will result in the schema
> > getting rejected.
> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > ---
> > Changes v3:
> > - Out of RFC
> > Changes v2:
> > - Add this patch
> > 
> >  .../devicetree/bindings/net/ethernet-phy.yaml | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > index 8fb2a6ee7e5b..9cb3981fed2a 100644
> > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> > @@ -213,6 +213,11 @@ properties:
> >        '#size-cells':
> >          const: 0
> >  
> > +      'active-low':
> 
> Drop quotes, no need for them.
> 
> As pointed out in other patchset, bool might not be enough.
> https://lore.kernel.org/all/74cb1d1c-64b8-4fb0-9e6d-c2fad8417232@lunn.ch/
> Anyway, both cases probably needs to be considered here.
>

Hi, thanks for pointing me to that series. Leaved some message there,
would love if you can check some ideas on how to handle the LED
polarity thing DT wise.

-- 
	Ansuel