netdev - Re: [PATCH net-next v5 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b7072c5-8b38-418f-b960-3c5401e8b18f@linaro.org>
Date: Fri, 15 Dec 2023 08:22:42 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Siddh Raman Pant <code@...dh.me>
Cc: "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Suman Ghosh <sumang@...vell.com>,
 netdev <netdev@...r.kernel.org>, linux-kernel
 <linux-kernel@...r.kernel.org>,
 syzbot+bbe84a4010eeea00982d
 <syzbot+bbe84a4010eeea00982d@...kaller.appspotmail.com>
Subject: Re: [PATCH net-next v5 1/2] nfc: llcp_core: Hold a ref to
 llcp_local->dev when holding a ref to llcp_local

On 14/12/2023 18:23, Siddh Raman Pant wrote:
> On Wed, 13 Dec 2023 13:10:16 +0530, Krzysztof Kozlowski wrote:
>>> -	if (sk_acceptq_is_full(parent)) {
>>> -		reason = LLCP_DM_REJ;
>>> -		release_sock(&sock->sk);
>>> -		sock_put(&sock->sk);
>>> -		goto fail;
>>> -	}
>>> +	if (sk_acceptq_is_full(parent))
>>> +		goto fail_put_sock;
>>
>> I would argue that you reshuffle here more code than needed for the fix.
>>
>> This should fix only missing dev reference, not reshuffle code. It's a
>> bugfix, not cleanup.
> 
> So this should not be done? I did it because you told to extend the
> cleanup label in v3 discussion.

It can be done but not in the same commit. You must not combine fixes
with other changes. Also, each commit is one logical change.

Best regards,
Krzysztof