[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZX3UNrHBYoPaPRWd@tissot.1015granger.net>
Date: Sat, 16 Dec 2023 11:45:42 -0500
From: Chuck Lever <chuck.lever@...cle.com>
To: Ahelenia Ziemiańska <nabijaczleweli@...ijaczleweli.xyz>
Cc: Trond Myklebust <trond.myklebust@...merspace.com>,
Anna Schumaker <anna@...nel.org>, Jeff Layton <jlayton@...nel.org>,
Olga Kornievskaia <kolga@...app.com>, Dai Ngo <Dai.Ngo@...cle.com>,
Tom Talpey <tom@...pey.com>, "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-nfs@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: sunrpc: sizeof('\0') is 4, not 1
On Sat, Dec 16, 2023 at 04:53:23PM +1100, NeilBrown wrote:
> On Sat, 16 Dec 2023, Ahelenia Ziemiańska wrote:
> > On Sat, Dec 16, 2023 at 03:27:16PM +1100, NeilBrown wrote:
> > > On Sat, 16 Dec 2023, Ahelenia Ziemiańska wrote:
> > > > To make it self-documenting, the referenced commit added the space
> > > > for the null terminator as sizeof('\0'). The message elaborates on
> > > > why only one byte is needed, so this is clearly a mistake.
> > > > Spell it as 1 /* NUL */ instead.
> > > >
> > > > Fixes: commit 1e360a60b24a ("SUNRPC: Address buffer overrun in
> > > > rpc_uaddr2sockaddr()")
> > > It isn't clear to me that "Fixes" is appropriate as that patch isn't
> > > harmful, just confused and sub-optimal.
> > I definitely agree, I don't like Fixes here at all,
> > but I don't really see another trailer in the documentation
> > or in the log that could be used for this.
> >
>
> Make up a new Trailer?
>
> I would probably just write
>
> To make it self-documenting,
> commit 1e360a60b24a ("SUNRPC: Address buffer overrun in rpc_uaddr2sockaddr()")
> added the space for the null terminator as sizeof('\0') which is 4. The commit
> elaborates on why only one byte is needed, so this is clearly a mistake.
> Spell it as 1 /* NUL */ instead.
Agreed; if Fixes: is overkill, simply spell out the commit that
introduced the issue in the patch description as Neil does here.
--
Chuck Lever
Powered by blists - more mailing lists