netdev - Re: [PATCH net-next 3/3] netlink: specs: use exact-len for IPv6 addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZX1kQQKZ7BdTAG15@Laptop-X1>
Date: Sat, 16 Dec 2023 16:48:01 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
	Davide Caratti <dcaratti@...hat.com>
Subject: Re: [PATCH net-next 3/3] netlink: specs: use exact-len for IPv6 addr

On Fri, Dec 15, 2023 at 06:09:11PM -0800, Jakub Kicinski wrote:
> On Fri, 15 Dec 2023 11:50:09 +0800 Hangbin Liu wrote:
> > We should use the exact-len instead of min-len for IPv6 address.
> 
> It does make sense, but these families historically used min-len..
> Not sure if it's worth changing this now or we risk regressions.

The addr6 in mptcp.yaml also use exact-len. I don't think the IPv6 address
could be larger than 16 bytes. So the min-len check looks incorrect.

Thanks
Hangbin