netdev - Re: [PATCH net-next 3/3] netlink: specs: use exact-len for IPv6 addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 12:40:27 +0100
From: Davide Caratti <dcaratti@...hat.com>
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 3/3] netlink: specs: use exact-len for IPv6 addr

hello Hangbin!

for the mptcp part: I didn't convert mptcp events, here transition
from min-len to exact-len should not generate issues at all.

Acked-by: Davide Caratti <dcaratti@...hat.com>

On Fri, Dec 15, 2023 at 4:50 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> We should use the exact-len instead of min-len for IPv6 address.
>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>  Documentation/netlink/specs/fou.yaml   | 4 ++--
>  Documentation/netlink/specs/mptcp.yaml | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/netlink/specs/fou.yaml b/Documentation/netlink/specs/fou.yaml
> index 0af5ab842c04..d472fd5055bd 100644
> --- a/Documentation/netlink/specs/fou.yaml
> +++ b/Documentation/netlink/specs/fou.yaml
> @@ -52,7 +52,7 @@ attribute-sets:
>          name: local_v6
>          type: binary
>          checks:
> -          min-len: 16
> +          exact-len: 16
>        -
>          name: peer_v4
>          type: u32
> @@ -60,7 +60,7 @@ attribute-sets:
>          name: peer_v6
>          type: binary
>          checks:
> -          min-len: 16
> +          exact-len: 16
>        -
>          name: peer_port
>          type: u16
> diff --git a/Documentation/netlink/specs/mptcp.yaml b/Documentation/netlink/specs/mptcp.yaml
> index 49f90cfb4698..2f694b79c3a7 100644
> --- a/Documentation/netlink/specs/mptcp.yaml
> +++ b/Documentation/netlink/specs/mptcp.yaml
> @@ -223,7 +223,7 @@ attribute-sets:
>          name: saddr6
>          type: binary
>          checks:
> -          min-len: 16
> +          exact-len: 16
>        -
>          name: daddr4
>          type: u32
> @@ -232,7 +232,7 @@ attribute-sets:
>          name: daddr6
>          type: binary
>          checks:
> -          min-len: 16
> +          exact-len: 16
>        -
>          name: sport
>          type: u16
> --
> 2.43.0
>
>