netdev - Re: [PATCH net-next] r8169: add support for LED's on RTL8168/RTL8101

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b7c1d91-7784-49d6-af2c-631c47ceadbd@gmail.com>
Date: Sat, 16 Dec 2023 13:28:48 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: add support for LED's on RTL8168/RTL8101

On 11.12.2023 17:05, Andrew Lunn wrote:
> On Thu, Dec 07, 2023 at 03:34:08PM +0100, Heiner Kallweit wrote:
>> This adds support for the LED's on most chip versions. Excluded are
>> the old non-PCIe versions and RTL8125. RTL8125 has a different LED
>> register layout, support for it will follow later.
>>
>> LED's can be controlled from userspace using the netdev LED trigger.
> 
> Since you cannot implement set_brightness, the hardware only supports
> offload, it probably makes sense to add Kconfig to enable the building
> of the netdev LED trigger. It seems pointless just having plain LEDs
> which can then usable.
> 
Right, therefore I create the LED devices only if
CONFIG_LEDS_TRIGGER_NETDEV is enabled:

#if IS_REACHABLE(CONFIG_LEDS_CLASS) && IS_ENABLED(CONFIG_LEDS_TRIGGER_NETDEV)
	[..]
	rtl8168_init_leds(dev);
#endif

Is this what you're referring to?

Using Kconfig select maybe problematic because it doesn't consider
dependencies. So we may have to use:
imply LEDS_TRIGGER_NETDEV
imply LEDS_TRIGGERS

> 	Andrew
Heiner