netdev - Re: [PATCH net-next] r8169: add support for LED's on RTL8168/RTL8101

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e897b56e-4f7b-4df0-9ac0-fe46a0558719@lunn.ch>
Date: Sat, 16 Dec 2023 13:53:19 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: add support for LED's on RTL8168/RTL8101

On Sat, Dec 16, 2023 at 01:28:48PM +0100, Heiner Kallweit wrote:
> On 11.12.2023 17:05, Andrew Lunn wrote:
> > On Thu, Dec 07, 2023 at 03:34:08PM +0100, Heiner Kallweit wrote:
> >> This adds support for the LED's on most chip versions. Excluded are
> >> the old non-PCIe versions and RTL8125. RTL8125 has a different LED
> >> register layout, support for it will follow later.
> >>
> >> LED's can be controlled from userspace using the netdev LED trigger.
> > 
> > Since you cannot implement set_brightness, the hardware only supports
> > offload, it probably makes sense to add Kconfig to enable the building
> > of the netdev LED trigger. It seems pointless just having plain LEDs
> > which can then usable.
> > 
> Right, therefore I create the LED devices only if
> CONFIG_LEDS_TRIGGER_NETDEV is enabled:
> 
> #if IS_REACHABLE(CONFIG_LEDS_CLASS) && IS_ENABLED(CONFIG_LEDS_TRIGGER_NETDEV)
> 	[..]
> 	rtl8168_init_leds(dev);
> #endif
> 
> Is this what you're referring to?

No, but that is a good alternative. I'm happy with this.

    Andrew