netdev - Re: [PATCH net-next] genetlink: Use internal flags for multicast groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZYBzzsZfUOkXGdpI@shredder>
Date: Mon, 18 Dec 2023 18:31:10 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: netdev@...r.kernel.org, mptcp@...ts.linux.dev, davem@...emloft.net,
	kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com,
	nhorman@...driver.com, matttbe@...nel.org, martineau@...nel.org,
	yotam.gi@...il.com, jiri@...nulli.us, jacob.e.keller@...el.com,
	johannes@...solutions.net, fw@...len.de
Subject: Re: [PATCH net-next] genetlink: Use internal flags for multicast
 groups

On Mon, Dec 18, 2023 at 01:37:41PM +0200, Andy Shevchenko wrote:
> No functional, but documentation changes...
> 
> So, I suggest to have these flags being described
> 
> /* ... */
> #define FLAG1
> 
> /* ... */
> #define FLAG2

OK, thanks. I will squash the following diff into v2:

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 5a402fd24817..bd6a6ffdec76 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -8,7 +8,9 @@
 
 #define GENLMSG_DEFAULT_SIZE (NLMSG_DEFAULT_SIZE - GENL_HDRLEN)
 
+/* Binding to multicast group requires %CAP_NET_ADMIN */
 #define GENL_MCAST_CAP_NET_ADMIN       BIT(0)
+/* Binding to multicast group requires %CAP_SYS_ADMIN */
 #define GENL_MCAST_CAP_SYS_ADMIN       BIT(1)
 
 /**