netdev - Re: [PATCH net] net/ipv6: Revert remove expired routes with a separated list of routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLGSJ-TaKfH002pqMyd2xfGybDkdrcGOm_Hn=2JsOKa=g@mail.gmail.com>
Date: Mon, 18 Dec 2023 17:31:06 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: David Ahern <dsahern@...nel.org>
Cc: netdev@...r.kernel.org, Kui-Feng Lee <thinker.li@...il.com>
Subject: Re: [PATCH net] net/ipv6: Revert remove expired routes with a
 separated list of routes

On Sun, Dec 17, 2023 at 7:55 PM David Ahern <dsahern@...nel.org> wrote:
>
> Revert the remainder of 5a08d0065a915 which added a warn on if a fib
> entry is still on the gc_link list, and then revert  all of the commit
> in the Fixes tag. The commit has some race conditions given how expires
> is managed on a fib6_info in relation to timer start, adding the entry
> to the gc list and setting the timer value leading to UAF. Revert
> the commit and try again in a later release.
>
> Fixes: 3dec89b14d37 ("net/ipv6: Remove expired routes with a separated list of routes")
> Cc: Kui-Feng Lee <thinker.li@...il.com>
> Signed-off-by: David Ahern <dsahern@...nel.org>

I guess we need two patches, one in net-next, one in net ?

If this patch targets net tree, it probably should be a plain revert
(no need to mention 5a08d0065a915)