netdev - Re: [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=ZKV6KsgX0UxBX4Y89YEgpry00jG6K6qSjodwY3DLAzA@mail.gmail.com>
Date: Mon, 18 Dec 2023 08:32:28 -0800
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Simon Horman <horms@...nel.org>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Nathan Chancellor <nathan@...nel.org>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, intel-wired-lan@...ts.osuosl.org, 
	netdev@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH iwl-next] i40e: Avoid unnecessary use of comma operator

On Sun, Dec 17, 2023 at 1:45 AM Simon Horman <horms@...nel.org> wrote:
>
> Although it does not seem to have any untoward side-effects,
> the use of ';' to separate to assignments seems more appropriate than ','.
>
> Flagged by clang-17 -Wcomma

Yikes! This kind of example is why I hate the comma operator!

Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

(Is -Wcomma enabled by -Wall?)

Is there a fixes tag we can add?

>
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Simon Horman <horms@...nel.org>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> index 812d04747bd0..f542f2671957 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
> @@ -1917,7 +1917,7 @@ int i40e_get_eeprom(struct net_device *netdev,
>                         len = eeprom->len - (I40E_NVM_SECTOR_SIZE * i);
>                         last = true;
>                 }
> -               offset = eeprom->offset + (I40E_NVM_SECTOR_SIZE * i),
> +               offset = eeprom->offset + (I40E_NVM_SECTOR_SIZE * i);
>                 ret_val = i40e_aq_read_nvm(hw, 0x0, offset, len,
>                                 (u8 *)eeprom_buff + (I40E_NVM_SECTOR_SIZE * i),
>                                 last, NULL);
>
>


-- 
Thanks,
~Nick Desaulniers