netdev - Re: [PATCH RESEND v2 net-next 02/12] tcp: Rearrange tests in inet_bind2_bucket_(addr_match|match_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK28G4O0vfF2U7Q175XiRc1NwdWOLbSRD9jqr7G=CQ+dg@mail.gmail.com>
Date: Tue, 19 Dec 2023 16:17:43 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 02/12] tcp: Rearrange tests in inet_bind2_bucket_(addr_match|match_addr_any)().

On Tue, Dec 19, 2023 at 1:19 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> The protocol family tests in inet_bind2_bucket_addr_match() and
> inet_bind2_bucket_match_addr_any() are ordered as follows.
>
>   if (sk->sk_family != tb2->family)
>   else if (sk->sk_family == AF_INET6)
>   else
>
> This patch rearranges them so that AF_INET6 socket is handled first
> to make the following patch tidy, where tb2->family will be removed.
>
>   if (sk->sk_family == AF_INET6)
>   else if (tb2->family == AF_INET6)
>   else
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>