netdev - Re: [PATCH RESEND v2 net-next 04/12] tcp: Save address type in inet_bind2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLongzRM7N9Jsaa2ugTC2eAnNVU=ntFsi3wddGJxsmqeA@mail.gmail.com>
Date: Tue, 19 Dec 2023 16:20:35 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH RESEND v2 net-next 04/12] tcp: Save address type in inet_bind2_bucket.

On Tue, Dec 19, 2023 at 1:20 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> inet_bind2_bucket_addr_match() and inet_bind2_bucket_match_addr_any()
> are called for each bhash2 bucket to check conflicts.  Thus, we call
> ipv6_addr_any() and ipv6_addr_v4mapped() over and over during bind().
>
> Let's avoid calling them by saving the address type in inet_bind2_bucket.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>