lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <693fb63e-8369-9cf7-4b41-7afc00b30618@amd.com> Date: Tue, 19 Dec 2023 09:35:32 -0800 From: Brett Creeley <bcreeley@....com> To: Lukasz Plachno <lukasz.plachno@...el.com>, intel-wired-lan@...ts.osuosl.org Cc: netdev@...r.kernel.org, Jakub Buchocki <jakubx.buchocki@...el.com>, Mateusz Pacuszka <mateuszx.pacuszka@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com> Subject: Re: [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules On 12/13/2023 8:34 PM, Lukasz Plachno wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Jakub Buchocki <jakubx.buchocki@...el.com> > > Add support for 'flow-type ether' Flow Director rules via ethtool. > > Rules not containing masks are processed by the Flow Director, > and support the following set of input parameters in all combinations: > src, dst, proto, vlan-etype, vlan, action. > > It is possible to specify address mask in ethtool parameters but only > 00:00:00:00:00 and FF:FF:FF:FF:FF are valid. > The same applies to proto, vlan-etype and vlan masks: > only 0x0000 and 0xffff masks are valid. Would it be useful to have user facing error messages for invalid masks stating what the valid masks are? > > Signed-off-by: Jakub Buchocki <jakubx.buchocki@...el.com> > Co-developed-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com> > Signed-off-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> > Signed-off-by: Lukasz Plachno <lukasz.plachno@...el.com> > --- > .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 128 +++++++++++++++++- > drivers/net/ethernet/intel/ice/ice_fdir.c | 27 ++++ > drivers/net/ethernet/intel/ice/ice_fdir.h | 11 ++ > drivers/net/ethernet/intel/ice/ice_type.h | 1 + > 4 files changed, 166 insertions(+), 1 deletion(-) > [...]
Powered by blists - more mailing lists