lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <bf21c58e-a857-4096-932a-cc9718ab9779@intel.com> Date: Wed, 20 Dec 2023 15:19:28 +0100 From: "Plachno, Lukasz" <lukasz.plachno@...el.com> To: Brett Creeley <bcreeley@....com>, <intel-wired-lan@...ts.osuosl.org> CC: <netdev@...r.kernel.org>, Jakub Buchocki <jakubx.buchocki@...el.com>, Mateusz Pacuszka <mateuszx.pacuszka@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com> Subject: Re: [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules On 12/19/2023 6:35 PM, Brett Creeley wrote: > > > On 12/13/2023 8:34 PM, Lukasz Plachno wrote: >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> From: Jakub Buchocki <jakubx.buchocki@...el.com> >> >> Add support for 'flow-type ether' Flow Director rules via ethtool. >> >> Rules not containing masks are processed by the Flow Director, >> and support the following set of input parameters in all combinations: >> src, dst, proto, vlan-etype, vlan, action. >> >> It is possible to specify address mask in ethtool parameters but only >> 00:00:00:00:00 and FF:FF:FF:FF:FF are valid. >> The same applies to proto, vlan-etype and vlan masks: >> only 0x0000 and 0xffff masks are valid. > > Would it be useful to have user facing error messages for invalid masks > stating what the valid masks are? > Do you think about something like: dev_warn("Driver only supports masks 00:00:00:00:00:00 and FF:FF:FF:FF:FF:FF"), or there is a way to pass custom message to ethtool to print it to user? >> >> Signed-off-by: Jakub Buchocki <jakubx.buchocki@...el.com> >> Co-developed-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com> >> Signed-off-by: Mateusz Pacuszka <mateuszx.pacuszka@...el.com> >> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> >> Signed-off-by: Lukasz Plachno <lukasz.plachno@...el.com> >> --- >> .../net/ethernet/intel/ice/ice_ethtool_fdir.c | 128 +++++++++++++++++- >> drivers/net/ethernet/intel/ice/ice_fdir.c | 27 ++++ >> drivers/net/ethernet/intel/ice/ice_fdir.h | 11 ++ >> drivers/net/ethernet/intel/ice/ice_type.h | 1 + >> 4 files changed, 166 insertions(+), 1 deletion(-) >> > > [...]
Powered by blists - more mailing lists