netdev - Re: [PATCH] net: fddi: skfp: Uninitialized data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231220143401.GH882741@kernel.org>
Date: Wed, 20 Dec 2023 15:34:01 +0100
From: Simon Horman <horms@...nel.org>
To: Alexander Sapozhnikov <alsp705@...il.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: fddi: skfp: Uninitialized data

On Tue, Dec 19, 2023 at 01:08:19PM +0300, Alexander Sapozhnikov wrote:
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Alexander Sapozhnikov <alsp705@...il.com>

Hi,

I think that more explanation is required regarding the problem
this solves and how it might affect users.

> ---
>  drivers/net/fddi/skfp/pmf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c
> index 563fb7f0b327..3f24fbd82a73 100644
> --- a/drivers/net/fddi/skfp/pmf.c
> +++ b/drivers/net/fddi/skfp/pmf.c
> @@ -1084,7 +1084,7 @@ static int smt_set_para(struct s_smc *smc, struct smt_para *pa, int index,
>  	int		path ;
>  	int		port ;
>  	SK_LOC_DECL(u_char,byte_val) ;
> -	SK_LOC_DECL(u_short,word_val) ;
> +	SK_LOC_DECL(u_short, word_val) = 0 ;
>  	SK_LOC_DECL(u_long,long_val) ;
>  
>  	mac = index - INDEX_MAC ;
> -- 
> 2.40.1
> 
>