netdev - Re: [PATCH net-next 00/15] Realtek RTL822x PHY rework to c45 and SerDes interface switching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220172518.50f56aaa@dellmb>
Date: Wed, 20 Dec 2023 17:25:18 +0100
From: Marek Behún <kabel@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Russell King <rmk+kernel@...linux.org.uk>, Alexander
 Couzens <lynxis@...0.eu>, Daniel Golle <daniel@...rotopia.org>, Willy Liu
 <willy.liu@...ltek.com>, Ioana Ciornei <ioana.ciornei@....com>, Marek
 Mojík <marek.mojik@....cz>, Maximilián
 Maliar <maximilian.maliar@....cz>
Subject: Re: [PATCH net-next 00/15] Realtek RTL822x PHY rework to c45 and
 SerDes interface switching

On Wed, 20 Dec 2023 17:20:07 +0100
Heiner Kallweit <hkallweit1@...il.com> wrote:

> On 20.12.2023 16:55, Marek Behún wrote:
> > Hi,
> > 
> > this series reworks the realtek PHY driver's support for rtl822x
> > 2.5G transceivers:
> > 
> > - First I change the driver so that the high level driver methods
> >   only use clause 45 register accesses (the only clause 22 accesses
> >   are left when accessing c45 registers indirectly, if the MDIO bus
> >   does not support clause 45 accesses).
> >   The driver starts using the genphy_c45_* methods.
> > 
> >   At this point the driver is ready to be used on a MDIO bus capable
> >   of only clause 45 accesses, but will still work on clause 22 only
> >   MDIO bus.
> > 
> > - I then add support for SerDes mode switching between 2500base-x
> >   and sgmii, based on autonegotiated copper speed.
> > 
> > All this is done so that we can support another 2.5G copper SFP
> > module, which is enabled by the last patch.
> >   
> 
> Has been verified that the RTL8125-integrated PHY's still work
> properly with this patch set?
> 

Hi Heiner,

no, I wanted to send you an email to test this. I do not have the
controllers with integrates PHYs.

Can you test this?

Also do you have a controller where the rtlgen driver is used but it
only supports 1gbps ? I.e. where the PHY ID is RTL_GENERIC_PHYID
(0x001cc800).

I am asking because I am told that it also is clause 45, so the drivers
can potentially be merged completely (the rtl822x_ functions can be
merged with rtlgen_ functions and everything rewritten to clause 45,
and gentphy_c45_ functions can be used).

Marek