netdev - RE: [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Dec 2023 23:54:47 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: "Sokolowski, Jan" <jan.sokolowski@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Kolacinski, Karol"
	<karol.kolacinski@...el.com>
Subject: RE: [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()



> -----Original Message-----
> From: Sokolowski, Jan <jan.sokolowski@...el.com>
> Sent: Thursday, December 21, 2023 2:20 AM
> To: Kolacinski, Karol <karol.kolacinski@...el.com>; intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Nguyen, Anthony L <anthony.l.nguyen@...el.com>;
> Brandeburg, Jesse <jesse.brandeburg@...el.com>; Keller, Jacob E
> <jacob.e.keller@...el.com>; Kolacinski, Karol <karol.kolacinski@...el.com>
> Subject: RE: [PATCH v4 iwl-next 5/6] ice: factor out ice_ptp_rebuild_owner()
> 
> >From: Jacob Keller <jacob.e.keller@...el.com>
> >
> >The ice_ptp_reset() function uses a goto to skip past clock owner
> >operations if performing a PF reset or if the device is not the clock
> >owner. This is a bit confusing. Factor this out into
> >ice_ptp_rebuild_owner() instead.
> 
> To me at least, the wording of the title (Factor out) is kinda
> confusing when compared to the message itself, as if you were going
> to remove the ice_ptp_rebuild_owner anyway.
> 
> Other than that, LGTM.
> 

Ya, the idea is to split the functionality into a separate function.